Improvements in angleiterator.cpp/h files by using cppcheck #1368
Conversation
…tion Class 'AngleIterator' has a constructor with 1 argument that is not explicit. Such, so called 'Converting constructors', should in general be explicit for type safety reasons as that prevents unintended implicit conversions. Signed-off-by: Surajjalpun2002 <[email protected]>
The use of valid here is unnecessary and doesn't have any effect because it's always false Condition valid is always false Signed-off-by: Surajjalpun2002 <[email protected]>
|
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
Surajjalpun2002
changed the title
|
Here are the build results |
Signed-off-by: Surajjalpun2002 <[email protected]>
|
I'm confused - why did you close this? are you opening a new PR? |
|
I am kinda new to github, and so i came here to a good first issue, but there were constant errors from the clang-format check leading me to believe i was making some mistake even after using clang-format tool. So, to not be annoying to anyone, i closed it. I would be thankful if you could point me in some direction. |
|
My suggestion would be to create a new branch off of OpenChemistry:master and If the check doesn't come back clean, I'll take care of it. |
|
I am making a new PR as a I deleted the forked repo last time, as the changes weren't much. |
Hey there,
I am creating this pull request to help with issue #1346.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.